Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new unsatisfied peer dependencies with latest verion #1516

Closed
travi opened this issue Dec 21, 2020 · 5 comments
Closed

new unsatisfied peer dependencies with latest verion #1516

travi opened this issue Dec 21, 2020 · 5 comments
Labels
🐛 bug Defect / Bug

Comments

@travi
Copy link
Member

travi commented Dec 21, 2020

i've been receiving renovate PRs for the new v7 in some of my projects now that you've promoted it to latest. i had upgraded a few of my projects to the prerelease of v7 already without issue.

however, i'm now seeing some new failures due to unsatisfied peer dependencies with the new version. you can see an example of this in this build output. i use npm ls to ensure that peer dependencies are compatible (it will exit non-zero if there is a conflict).

the projects that i'm seeing these issues in are not react projects, so i have no reason to depend on the peer packages other than because of the use of cucumber, so i would prefer not to depend on them directly. could you please satisfy these peer dependencies on your end by making them prod dependencies of cucumber?

@davidjgoss davidjgoss added the 🐛 bug Defect / Bug label Dec 22, 2020
@davidjgoss
Copy link
Contributor

davidjgoss commented Dec 22, 2020

Thanks for raising @travi

These React-related dependencies come via our HTML formatter and some React libraries it uses.

peer dep missing: react@^16.3.2, required by react-accessible-accordion@3.3.3
peer dep missing: react-dom@^16.3.3, required by react-accessible-accordion@3.3.3

There's already a PR merged to allow React 17 for react-accessible-accordion here springload/react-accessible-accordion#307 so hopefully that'll get released shortly and we can bring that in.

peer dep missing: @types/react@>=16, required by react-markdown@5.0.3

I'll raise it with that project. I don't think it should require consuming projects to install types for react.

@travi
Copy link
Member Author

travi commented Dec 22, 2020

sounds great. thanks a lot for digging in on this :)

@ericlanteigne-quest
Copy link

ericlanteigne-quest commented Mar 22, 2021

Has there been any update on this? We are also encountering this when installing version 7.0.0.
npm ERR! peer dep missing: @types/react@>=16, required by react-markdown@5.0.3

@davidjgoss
Copy link
Contributor

Hey @ericlanteigne-quest - the fix is done and this should be released soon.

@davidjgoss davidjgoss assigned davidjgoss and unassigned davidjgoss Apr 2, 2021
@davidjgoss
Copy link
Contributor

7.1.0 was released today including the fix for this https://www.npmjs.com/package/@cucumber/cucumber/v/7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

No branches or pull requests

4 participants