html-formatter: reclassify webpack-bundled dependencies to be dev dependencies #1308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change
dependencies
that are wrapped into the webpack bundle to bedevDependencies
, to reduce unnecessary dependency footprint of cucumber-js and projects which consume it.Motivation and Context
Because
cucumber-js
depends on@cucumber/html-formatter
, it brings anydependencies
with it. Currently that includes several cucumber packages plusreact
andreact-dom
which isn't necessary since these are inlined into the JS bundle by webpack so we don't need them when we're using the already-built package. It's also confusing for users and the extend dependency tree can cause other issues. See:Types of changes
Checklist: