Skip to content

Commit

Permalink
chore: fix typos (#2391)
Browse files Browse the repository at this point in the history
  • Loading branch information
asashour committed Apr 21, 2024
1 parent e75764d commit 9dde5d0
Show file tree
Hide file tree
Showing 13 changed files with 31 additions and 31 deletions.
2 changes: 1 addition & 1 deletion dependency-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ignoreErrors:
shouldBeDevDependency:
- '@cucumber/message-streams' # peer dependency of @cucumber/gherkin-streams
unused:
- '@cucumber/compatibility-kit' # files dynamically loaded in cck test, not require'd
- '@cucumber/compatibility-kit' # files dynamically loaded in cck test, not required
- '@typescript-eslint/eslint-plugin' # peer dependency of standard-with-typescript
- '@typescript-eslint/parser' # peer dependency of @typescript-eslint/eslint-plugin
- '@types/*' # type definitions
Expand Down
2 changes: 1 addition & 1 deletion docs/first-time-contributor-tutorial.md
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ This option applies to the progress formatter and the summary formatter.
```
Now we should add an entry in the CHANGELOG.md. Open it, locate the `### Added` section
for the unreleased changes, and add somethig about the changes we just did:
for the unreleased changes, and add something about the changes we just did:
```markdown

Expand Down
2 changes: 1 addition & 1 deletion docs/retro/2021/07/17.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ This retrospective was from the first [new contributors mob/ensemble]. Sadly [@m

* Do this regularly but on any codebase, not just Cucumber
* Would it be easier to just run it locally on one of our machines?
* Matt do more homeowrk on twitch setup
* Matt do more homework on twitch setup
* Let's do this again!
* Update CONTRIBUTING.md guide to include pointers to basics about forking, how to name your branch etc., and some words of comfort and encouragement to make mistakes, ask for help etc.

Expand Down
4 changes: 2 additions & 2 deletions docs/retro/2022/01/21.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
* Matt: Our docs don't give people enough context as they arrive - straight into the guts of installation without any signposts
* Matt: How much we discovered about a problem I thought was simple. I love example mapping!
* Kate: I wanted to be more actively participating in the miro board. More hands on. Was it a lack of familiarity? Should we have mad more formal mob roles? What are the rules of the example mapping game?
* Kate: It was fun, thankyou!
* Kate: It was fun, thank you!

## Actions

* Matt: figure out where we should implement this - in the existing commitbit repo or somewhere else?
* Kate: think about the process and formalising exmaple mapping
* Kate: think about the process and formalising example mapping
8 changes: 4 additions & 4 deletions features/data_tables.feature
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Feature: Data Tables
Given a table step
| Vegetable | Rating |
| Apricot | 5 |
| Brocolli | 2 |
| Broccoli | 2 |
| Cucumber | 10 |
"""
Given a file named "features/step_definitions/passing_steps.js" with:
Expand All @@ -44,7 +44,7 @@ Feature: Data Tables
Given(/^a table step$/, function(table) {
const expected = [
['Apricot', '5'],
['Brocolli', '2'],
['Broccoli', '2'],
['Cucumber', '10']
]
assert.deepEqual(table.rows(), expected)
Expand Down Expand Up @@ -86,7 +86,7 @@ Feature: Data Tables
Given a table step
| Vegetable | Rating |
| Apricot | 5 |
| Brocolli | 2 |
| Broccoli | 2 |
| Cucumber | 10 |
"""
Given a file named "features/step_definitions/passing_steps.js" with:
Expand All @@ -97,7 +97,7 @@ Feature: Data Tables
Given(/^a table step$/, function(table) {
const expected = [
{'Vegetable': 'Apricot', 'Rating': '5'},
{'Vegetable': 'Brocolli', 'Rating': '2'},
{'Vegetable': 'Broccoli', 'Rating': '2'},
{'Vegetable': 'Cucumber', 'Rating': '10'}
]
assert.deepEqual(table.hashes(), expected)
Expand Down
2 changes: 1 addition & 1 deletion features/step_definition_snippets_interfaces.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Feature: step definition snippets custom syntax

As a developer writing my step definitions in another JS dialect
I want to be able to see step definition snippets in the language I perfer
I want to be able to see step definition snippets in the language I prefer

Background:
Given a file named "features/undefined.feature" with:
Expand Down
6 changes: 3 additions & 3 deletions features/step_definitions/parallel_steps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function getSetsOfPicklesRunningAtTheSameTime(
): string[] {
const pickleIdToName: Record<string, string> = {}
const testCaseIdToPickleId: Record<string, string> = {}
const testCaseStarteIdToPickleId: Record<string, string> = {}
const testCaseStartedIdToPickleId: Record<string, string> = {}
let currentRunningPickleIds: string[] = []
const result: string[] = []
envelopes.forEach((envelope) => {
Expand All @@ -18,7 +18,7 @@ function getSetsOfPicklesRunningAtTheSameTime(
testCaseIdToPickleId[envelope.testCase.id] = envelope.testCase.pickleId
} else if (envelope.testCaseStarted != null) {
const pickleId = testCaseIdToPickleId[envelope.testCaseStarted.testCaseId]
testCaseStarteIdToPickleId[envelope.testCaseStarted.id] = pickleId
testCaseStartedIdToPickleId[envelope.testCaseStarted.id] = pickleId
currentRunningPickleIds.push(pickleId)
if (currentRunningPickleIds.length > 1) {
const setOfPickleNames = currentRunningPickleIds
Expand All @@ -29,7 +29,7 @@ function getSetsOfPicklesRunningAtTheSameTime(
}
} else if (envelope.testCaseFinished != null) {
const pickleId =
testCaseStarteIdToPickleId[envelope.testCaseFinished.testCaseStartedId]
testCaseStartedIdToPickleId[envelope.testCaseFinished.testCaseStartedId]
currentRunningPickleIds = currentRunningPickleIds.filter(
(x) => x != pickleId
)
Expand Down
2 changes: 1 addition & 1 deletion features/usage_formatter.feature
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Feature: usage formatter

As a developer with slow or unused steps
I want a formatter which just outputs the step definition usage
So I know where my bottelnecks are and what step definitions I can remove
So I know where my bottlenecks are and what step definitions I can remove


Scenario:
Expand Down
2 changes: 1 addition & 1 deletion src/cli/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export function orderPickles<T = string>(
break
default:
throw new Error(
'Unrecgonized order type. Should be `defined` or `random`'
'Unrecognized order type. Should be `defined` or `random`'
)
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/formatter/helpers/formatters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ const Formatters = {
}
},
buildFormattersDocumentationString(): string {
let concatanatedFormattersDocumentation: string = ''
let concatenatedFormattersDocumentation: string = ''
const formatters = this.getFormatters()
for (const formatterName in formatters) {
concatanatedFormattersDocumentation += ` ${formatterName}: ${formatters[formatterName].documentation}\n`
concatenatedFormattersDocumentation += ` ${formatterName}: ${formatters[formatterName].documentation}\n`
}

return concatanatedFormattersDocumentation
return concatenatedFormattersDocumentation
},
}

Expand Down
20 changes: 10 additions & 10 deletions src/formatter/step_definition_snippet_builder/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('StepDefinitionSnippetBuilder', () => {
describe('build()', () => {
describe('step is an precondition step', () => {
it('uses Given as the function name', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('Given abc')

// Act
Expand All @@ -43,7 +43,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step is an event step', () => {
it('uses When as the function name', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('When abc')

// Act
Expand All @@ -59,7 +59,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step is an outcome step', () => {
it('uses Then as the function name', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('Then abc')

// Act
Expand All @@ -75,7 +75,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step has simple name', () => {
it('adds the proper generated expression', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('Given abc')

// Act
Expand All @@ -94,7 +94,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step name has a quoted string', () => {
it('adds the proper generated expression', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('Given abc "def" ghi')

// Act
Expand All @@ -112,7 +112,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step name has multiple quoted strings', () => {
it('adds the proper generated expression', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText(
'Given abc "def" ghi "jkl" mno'
)
Expand All @@ -134,7 +134,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step name has a standalone number', () => {
it('adds the proper generated expression', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('Given abc 123 def')

// Act
Expand All @@ -152,7 +152,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step has no argument', () => {
it('passes no step parameter names', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText('Given abc')

// Act
Expand All @@ -168,7 +168,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step has a data table argument', () => {
it('passes dataTable as a step parameter name', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText(`\
Given abc
| a |`)
Expand All @@ -186,7 +186,7 @@ describe('StepDefinitionSnippetBuilder', () => {

describe('step has a doc string argument', () => {
it('passes docString as a step parameter name', async function () {
// Arrrange
// Arrange
const pickleStep = await getPickleStepWithText(`
Given abc
"""
Expand Down
4 changes: 2 additions & 2 deletions src/models/step_definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ export default class StepDefinition extends Definition implements IDefinition {
this.expression.match(step.text).map((arg) => arg.getValue(world))
)
if (doesHaveValue(step.argument)) {
const argumentParamater = parseStepArgument<any>(step.argument, {
const argumentParameter = parseStepArgument<any>(step.argument, {
dataTable: (arg) => new DataTable(arg),
docString: (arg) => arg.content,
})
parameters.push(argumentParamater)
parameters.push(argumentParameter)
}
return {
getInvalidCodeLengthMessage: () =>
Expand Down
2 changes: 1 addition & 1 deletion src/user_code_runner_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ describe('UserCodeRunner', () => {
})
})

describe('function calls back with non-serializable rror', () => {
describe('function calls back with non-serializable error', () => {
it('returns the error', async function () {
// Arrange
const fn = function (callback: CallbackFn): void {
Expand Down

0 comments on commit 9dde5d0

Please sign in to comment.