-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): add http argument parser #3300
Conversation
✅ Deploy Preview for cubefs-check ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
+ Coverage 40.49% 40.56% +0.06%
==========================================
Files 603 606 +3
Lines 125057 124981 -76
==========================================
+ Hits 50643 50694 +51
+ Misses 70051 69922 -129
- Partials 4363 4365 +2 ☔ View full report in Codecov by Sentry. |
e18a509
to
34d3659
Compare
0de06e8
to
6e16b3f
Compare
b1282d6
to
b044416
Compare
b3b20d3
to
2ee8815
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d1e5c6c
to
2a1245b
Compare
0eb34d7
to
6bdea07
Compare
7cc73e5
to
468a6f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
. #22032837 of #22032813 Signed-off-by: slasher <shenjie1@oppo.com>
. #22032841 of #22032813 Signed-off-by: slasher <shenjie1@oppo.com>
Motivation
Parse http argument in common package.
Modifications
Types of changes
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
doc-not-needed
doc-complete
Review Expection
in-two-days
weeks
free-time
whenever