Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracelog): logging with trace #3175

Closed
wants to merge 33 commits into from
Closed

chore(tracelog): logging with trace #3175

wants to merge 33 commits into from

Conversation

sejust
Copy link
Collaborator

@sejust sejust commented Mar 5, 2024

Motivation

Logging with trace in all modules.

Modifications

  • Logging with span in inner mudule.
  • Passing trace id with http header.
  • Carry request id with tcp package.
  • TODO, apply with trace in Raft.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)
  • So on...

Verifying this change

  • Make sure that the change passes the testing checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Master
  • MetaNode
  • DataNode
  • ObjectNode
  • AuthNode
  • LcNode
  • Blobstore
  • Client
  • Cli
  • SDK
  • Other Tools
  • Common Packages
  • Dependencies
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Review Expection

  • in-two-days
  • weekly
  • free-time
  • whenever

@sejust sejust marked this pull request as draft March 5, 2024 06:05
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 8a6b2dc
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/6641f6ff72ba510008456ef1
😎 Deploy Preview https://deploy-preview-3175--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sejust sejust force-pushed the blobstore-tracelog branch 3 times, most recently from 253aa50 to 9297dff Compare March 5, 2024 08:41
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 24.15830% with 1284 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (6ad04f6) to head (dc4a988).
Report is 90 commits behind head on master.

❗ Current head dc4a988 differs from pull request most recent head 8a6b2dc. Consider uploading reports for the commit 8a6b2dc to get more accurate results

Files Patch % Lines
datanode/wrap_operator.go 0.00% 175 Missing ⚠️
master/data_partition.go 40.00% 133 Missing and 8 partials ⚠️
datanode/partition.go 0.00% 136 Missing ⚠️
master/cluster_task.go 49.00% 82 Missing and 21 partials ⚠️
datanode/partition_raft.go 0.00% 95 Missing ⚠️
datanode/server.go 0.00% 85 Missing ⚠️
datanode/data_partition_repair.go 0.00% 76 Missing ⚠️
datanode/disk.go 0.00% 68 Missing ⚠️
lcnode/server.go 10.20% 44 Missing ⚠️
lcnode/snapshot_scanner.go 44.92% 37 Missing and 1 partial ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
+ Coverage   41.92%   42.86%   +0.94%     
==========================================
  Files         581      581              
  Lines      119805   118144    -1661     
==========================================
+ Hits        50228    50643     +415     
+ Misses      65265    63189    -2076     
  Partials     4312     4312              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejust sejust force-pushed the blobstore-tracelog branch 12 times, most recently from a967516 to f0100e2 Compare March 13, 2024 01:59
@sejust sejust added tracelog and removed tracelog labels Mar 13, 2024
@sejust sejust changed the title chore(metanode): logging with trace chore(tracelog): logging with trace Mar 13, 2024
@sejust sejust force-pushed the blobstore-tracelog branch 4 times, most recently from 384eb18 to 8fdc9ec Compare March 19, 2024 11:25
@yansenliang yansenliang force-pushed the blobstore-tracelog branch 3 times, most recently from 106a313 to 376e424 Compare March 20, 2024 06:38
@sejust sejust marked this pull request as ready for review March 21, 2024 12:05
cefufu and others added 16 commits March 22, 2024 11:12
with #21965653

Signed-off-by: fucefu <fucefu@oppo.com>
with #21965653

Signed-off-by: fucefu <fucefu@oppo.com>
with #21966102

Signed-off-by: slasher <mcq.sejust@gmail.com>
with #21965653

Signed-off-by: fucefu <fucefu@oppo.com>
with #21965653

Signed-off-by: xiejian <xiejian3@oppo.com>
with #21974670

Signed-off-by: slasher <mcq.sejust@gmail.com>
with #21965811

Signed-off-by: slasher <mcq.sejust@gmail.com>
with #21965653

Signed-off-by: fucefu <fucefu@oppo.com>
with #21965811

Signed-off-by: slasher <mcq.sejust@gmail.com>
with #21965811

Signed-off-by: slasher <mcq.sejust@gmail.com>
with #21965653

Signed-off-by: fucefu <fucefu@oppo.com>
with #21965691

Signed-off-by: yhjiango <jiangyunhua@oppo.com>
with #21965811

Signed-off-by: slasher <shenjie1@oppo.com>
with #21965679

Signed-off-by: yansenliang <liangyansen@oppo.com>
with #21965679

Signed-off-by: yansenliang <liangyansen@oppo.com>

Signed-off-by: yansenliang <liangyansen@oppo.com>
with #21965811

Signed-off-by: slasher <shenjie1@oppo.com>
@sejust sejust force-pushed the blobstore-tracelog branch 2 times, most recently from 21e998e to 8e97c43 Compare March 22, 2024 03:39
with #21965811

Signed-off-by: slasher <shenjie1@oppo.com>
with #21965811

Signed-off-by: slasher <shenjie1@oppo.com>
@sejust sejust force-pushed the blobstore-tracelog branch 2 times, most recently from dc4a988 to b7af5ca Compare March 27, 2024 06:26
with #21965811

Signed-off-by: slasher <shenjie1@oppo.com>
@sejust sejust added the NEED RESOLVE CONFLICT Need for conflict resolution label May 14, 2024
@sejust
Copy link
Collaborator Author

sejust commented May 24, 2024

There has many conflicts, create merge request later.

@sejust sejust closed this May 24, 2024
@sejust sejust deleted the blobstore-tracelog branch May 28, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEED RESOLVE CONFLICT Need for conflict resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants