enhance(client): improve the client restore process #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cubefs-check ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
liubingxing
force-pushed
the
github_client
branch
from
8b1ca68
to
2e90299
Compare
liubingxing
changed the title
liubingxing
force-pushed
the
github_client
branch
2 times, most recently
from
ed9fdbf
to
ed5abf7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
==========================================
- Coverage 45.27% 44.94% -0.33%
==========================================
Files 448 446 -2
Lines 71837 71805 -32
==========================================
- Hits 32521 32276 -245
- Misses 37056 37292 +236
+ Partials 2260 2237 -23
... and 74 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@leonrayang @Victor1319 Please take a look at this PR. Thanks a lot. |
bboyCH4
previously approved these changes
Jun 7, 2023
Signed-off-by: liubingxing <liubbingxing@gmail.com>
Signed-off-by: liubingxing <liubbingxing@gmail.com>
liubingxing
force-pushed
the
github_client
branch
from
ed5abf7
to
de09687
Compare
|
@sejust Code conflict resolved, please review again. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following figure shows the process of upgrading cfs-client. This is a good feature and we want to use it in production environment.
We tested it for a while and found some problems, especially when the old client processing quit but the new client failed to start up, will cause the test failed.
So we want to improve the process that the old client waits until the new client restored data.
The main changes are as follow: