Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改其他连接错误 #801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

修改其他连接错误 #801

wants to merge 1 commit into from

Conversation

Ascotbe
Copy link
Contributor

@Ascotbe Ascotbe commented Aug 2, 2021

  • unsorted-bin-attack 这个文件文件原作者移动到glibc_2.27和glibc_2.23这两个文件夹中，和文中的内容不同，应该做过修改了，可以看下是否正确
  • 其他的是连接错误

最后提个建议

写文章的时候使用commit的序列号作为连接，这样就不会有引用连接错误问题

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

📝 Docs preview for commit 6a2bafe at: https://610797308de07fac02dda3b4--modest-austin-48be4a.netlify.app

bash-c
bash-c reviewed Aug 4, 2021
View reviewed changes
Copy link
Contributor

@bash-c bash-c left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的超链接错误不能简单地从2.25修改到2.27，不同版本的glibc mitigation不同，利用方法也不一样，除了更新超链接还需要确保更新对应文档内容。

这一点由于我们人手不足并且远离glibc多年，欢迎师傅@Ascotbe提交pr ：）

不过使用commit id做为超链接确实是一种比较保险的方案，但具体可行性需要讨论一下，cc @iromise

docs/zh/docs/pwn/linux/user-mode/heap/ptmalloc2/tcache-attack.md
@@ -734,7 +734,7 @@ tcache_put (mchunkptr chunk, size_t tc_idx)

因为没有任何检查，所以我们可以对同一个 chunk 多次 free，造成 cycliced list。

以 how2heap 的 [tcache_dup](https://github.com/shellphish/how2heap/blob/master/glibc_2.26/tcache_dup.c) 为例分析，源码如下：
以 how2heap 的 [tcache_dup](https://github.com/shellphish/how2heap/blob/master/glibc_2.27/tcache_dup.c) 为例分析，源码如下：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该链接404

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只是提个建议，毕竟文档多起来如果引用其他项目不使用commit id，不是很好管理

PS:堆方面我还是初学者就不班门弄斧了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bash-c @Ascotbe 使用 commit id 作为超链接确实是不错的解决方案。针对目前的情况，具体要改到哪一个 commit id 估计得手工找一下。不过最近比较忙，暂时没有时间来处理这个 o(╥﹏╥)o 。@Ascotbe 欢迎在学习的过程中给出 PR 鸭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bash-c 好的，我有空就提交PR

@bash-c bash-c requested a review from iromise August 4, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bash-c bash-c bash-c left review comments

@iromise iromise Awaiting requested review from iromise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ascotbe @iromise @bash-c