Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up 2024, silently prepare for 2025, improve usability (homepage link) #158

Merged
merged 21 commits into from
May 19, 2024

Conversation

j9t
Copy link
Member

@j9t j9t commented Apr 12, 2024

Fairly simple PR to wrap up and prepare.

A site refactoring (maybe using Eleventy or some other SSG) would make all of this easier and less error-prone… maybe something to discuss in the next years :)

j9t added 5 commits April 12, 2024 13:41
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
(including minimal “reset” to keep previous styling)

Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
@j9t j9t requested a review from arkhi April 12, 2024 11:50
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
@arkhi
Copy link
Member

arkhi commented Apr 14, 2024

Hello Jens,

I’ve had eleventy in mind for years but I’m not able to prioritise time to actually do it. So all for it, yes.


About adding anchors to titles. This troubles me as, semantically, this does not seem right to me:

  • Titles are all linking to the home page when the title is actually not about the home page.
  • Adding the anchor on the title of the home page is redundant since we are on the home page already and the content of the page only changes when reloaded.
  • We have a “Home” link that provides this navigation in the list on each page.

I know it’s an affordance to have a link on the h1 in the case the title is stable across pages, which is not our case.

What do you think?

owenblacker and others added 3 commits April 14, 2024 12:00
Change to past tense
@j9t
Copy link
Member Author

j9t commented Apr 14, 2024

Hi @arkhi—do you want to move this into a review? Happy to respond here, too, though:

First, sorry for not providing extra context—this PR was thought to contain some quick fixes, not perfect solutions. We’ve been working on this site for some time so I had thought you could tell it was a quick iteration.

About adding anchors to titles. This troubles me as, semantically, this does not seem right to me:

  • Titles are all linking to the home page when the title is actually not about the home page.

See above, quick improvement. We could mitigate by just linking “CSS Naked Day” itself. It’s a compromise, but might better meet user expectations and also keep the scheme consistent.

  • Adding the anchor on the title of the home page is redundant since we are on the home page already and the content of the page only changes when reloaded.

Absolutely. I opted for it because it’s consistently wrong on all pages. The “no links to active page” issue should be addressed in some future clean-up, but I opted against making it a concern in this clean-up.

  • We have a “Home” link that provides this navigation in the list on each page.

Which breaks user expectations though—that link can’t even be considered part of some navigation. (I don’t consider it part of that, if you feel this is a “typical” spot for a homepage link. It really is the site logo or title normally.)

I know it’s an affordance to have a link on the h1 in the case the title is stable across pages, which is not our case.

I think you’re understanding the problem. As mentioned, perhaps another compromise could be to just link the “CSS Naked Day” part.

—By the way, I didn’t build the original website. There are many problems with it, but those should probably not be used against anyone who tries to improve the site.

andrecasal and others added 4 commits April 15, 2024 08:35
Added andrecasal.com
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
@j9t
Copy link
Member Author

j9t commented Apr 20, 2024

Could you advise, @arkhi?

j9t added 8 commits May 19, 2024 17:21
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
(including minimal “reset” to keep previous styling)

Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
…-wrapup

# Conflicts:
#	2006.html
#	2007.html
#	2008.html
#	2009.html
#	2015.html
#	2020.html
#	2021.html
#	2022.html
#	2023.html
#	2024.html
#	2025.html
@j9t
Copy link
Member Author

j9t commented May 19, 2024

Reworked headings to strike balance between my suggestion to offer a more prominent, conventional home link and @arkhi’s concerns about linking the header, by only linking “CSS Naked Day.”

Merging given Fabien’s limited availability; will follow up on the respective email conversation.

@j9t j9t merged commit 5f8da92 into master May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants