-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap up 2024, silently prepare for 2025, improve usability (homepage link) #158
Conversation
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
(including minimal “reset” to keep previous styling) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Hello Jens, I’ve had eleventy in mind for years but I’m not able to prioritise time to actually do it. So all for it, yes. About adding anchors to titles. This troubles me as, semantically, this does not seem right to me:
I know it’s an affordance to have a link on the What do you think? |
Change to past tense
Change 2024 to past tense
Revise README (open to discussion)
Hi @arkhi—do you want to move this into a review? Happy to respond here, too, though: First, sorry for not providing extra context—this PR was thought to contain some quick fixes, not perfect solutions. We’ve been working on this site for some time so I had thought you could tell it was a quick iteration.
See above, quick improvement. We could mitigate by just linking “CSS Naked Day” itself. It’s a compromise, but might better meet user expectations and also keep the scheme consistent.
Absolutely. I opted for it because it’s consistently wrong on all pages. The “no links to active page” issue should be addressed in some future clean-up, but I opted against making it a concern in this clean-up.
Which breaks user expectations though—that link can’t even be considered part of some navigation. (I don’t consider it part of that, if you feel this is a “typical” spot for a homepage link. It really is the site logo or title normally.)
I think you’re understanding the problem. As mentioned, perhaps another compromise could be to just link the “CSS Naked Day” part. —By the way, I didn’t build the original website. There are many problems with it, but those should probably not be used against anyone who tries to improve the site. |
Added andrecasal.com
Update 2024.html
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Could you advise, @arkhi? |
docs: add Wikipedia draft ref?
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
(including minimal “reset” to keep previous styling) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
…-wrapup # Conflicts: # 2006.html # 2007.html # 2008.html # 2009.html # 2015.html # 2020.html # 2021.html # 2022.html # 2023.html # 2024.html # 2025.html
Reworked headings to strike balance between my suggestion to offer a more prominent, conventional home link and @arkhi’s concerns about linking the header, by only linking “CSS Naked Day.” Merging given Fabien’s limited availability; will follow up on the respective email conversation. |
Fairly simple PR to wrap up and prepare.
A site refactoring (maybe using Eleventy or some other SSG) would make all of this easier and less error-prone… maybe something to discuss in the next years :)