Merge pull request #309 from cschleiden/remove-more-panics

Remove remaining panics
cschleiden · Jan 21, 2024 · c5d50c3 · c5d50c3
2 parents 9fbfb31 + e961fa1
commit c5d50c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/worker/workflow.go b/internal/worker/workflow.go
@@ -78,7 +78,7 @@ func (wtw *WorkflowTaskWorker) Complete(ctx context.Context, result *workflow.Ex
 	if err := wtw.backend.CompleteWorkflowTask(
 		ctx, t, t.WorkflowInstance, state, result.Executed, result.ActivityEvents, result.TimerEvents, result.WorkflowEvents); err != nil {
 		wtw.logger.ErrorContext(ctx, "could not complete workflow task", "error", err)
-		panic("could not complete workflow task")
+		return fmt.Errorf("completing workflow task: %w", err)
 	}
 
 	return nil

diff --git a/internal/workflow/executor.go b/internal/workflow/executor.go
@@ -245,7 +245,7 @@ func (e *executor) replayHistory(h []*history.Event) error {
 	for _, event := range h {
 		if event.SequenceID < e.lastSequenceID {
 			e.logger.Error("history has older events than current state")
-			panic("history has older events than current state")
+			return errors.New("history has older events than current state")
 		}
 
 		if err := e.executeEvent(event); err != nil {