Integration between GameEngine and Rendering #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-star-dash into feat/rendering
…-star-dash into feat/rendering
Junyi00
requested review from
ruihan00,
HoJunHao2000 and
jasonqiu212
and removed request for
ruihan00 and
HoJunHao2000
jasonqiu212
reviewed
Mar 16, 2024
jasonqiu212
reviewed
Mar 16, 2024
jasonqiu212
changed the title
jasonqiu212
approved these changes
Mar 16, 2024
|
LGTM |
HoJunHao2000
approved these changes
Mar 17, 2024
| } | ||
|
|
||
| func sync(entity: Entity, from object: SDObject) { | ||
| guard let positionComponent = entityManager.component(ofType: PositionComponent.self, of: entity.id) else { |
There was a problem hiding this comment.
Should the syncing be done through system manager? I did create a sync function in the position and physics systems (parameters may not be the same but that can easily be fixed in systems).
Works either way to be honest. But i just thought that systems are responsible for transforming component data.
There was a problem hiding this comment.
I believe this approach makes for better design since our game engine has one less responsibility and reduced coupling to the physics engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Note:
GameEngine.EntityManageras non-private to create the test game scene from view controllerTextureComponentis to-be-updatedforceattribute, commented out temporarilyPhysicsComponentis to-be-updated to expose shapes of physics body