Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining events #7

Merged
merged 25 commits into from Mar 17, 2024
Merged

Add remaining events #7

merged 25 commits into from Mar 17, 2024

Conversation

jasonqiu212
Copy link
Contributor

@jasonqiu212 jasonqiu212 commented Mar 15, 2024

Changes

  • Added MoveEvent
  • Added JumpEvent
  • Added draft PickupCollectibleEvent
  • Added draft UseGrappleHookEvent
  • Added events related to player attacking monster
  • Added events related to monster attacking player

Todo

  • PlayerMonsterContactEvent: Determine if player is directly on top of monster and send corresponding attack event
  • PickupCollectibleEvent: How should we keep track of score?
  • PlayerDeathEvent: Where should players respawn to?
  • UseGrappleHookEvent: What is the physics like for the grapple hook?

@jasonqiu212 jasonqiu212 marked this pull request as ready for review March 17, 2024 07:38
@jasonqiu212 jasonqiu212 self-assigned this Mar 17, 2024
@jasonqiu212 jasonqiu212 requested review from HoJunHao2000 and Junyi00 and removed request for HoJunHao2000 March 17, 2024 07:42
@jasonqiu212 jasonqiu212 requested review from ruihan00, HoJunHao2000 and Junyi00 and removed request for HoJunHao2000 and Junyi00 March 17, 2024 07:42
Copy link
Contributor

@HoJunHao2000 HoJunHao2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonqiu212 jasonqiu212 merged commit ddb30c1 into main Mar 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants