Feat/extend background image #52
Conversation
There was a problem hiding this comment.
The overall implementation looks good and I appreciate the refactoring of the initialisation of GameEngine, GameScene and others.
But I feel that there needs be a larger refactoring around the initialisation of the GameEngine itself. The loading of map entities, creation of player entities and creation of background image should probably not be the responsibility of the view controller... But I understand if this should be in another PR or if u would like to resolve it in this PR would be good too!
| @@ -37,17 +40,24 @@ class ViewController: UIViewController { | |||
| self.renderer = renderer | |||
| } | |||
|
|
|||
| func setupGameEntities() { | |||
| private func createGameEngine() -> GameEngine { | |||
| let levelSize = self.storageManager?.getLevelSize(id: 0) ?? CGSize(width: 4_842, height: 1_040) | |||
There was a problem hiding this comment.
I believe the id here should be consistent with method setupGameEntities, by passing a variable?
|
I agree that the game engine should handle the setting up of the entities, I will resolve this in the pr for Home Screen as it requires a refactoring of the game engine to set up the game |
Resolves #37