Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/fix tests after ECS refactor #43

Merged
merged 1 commit into from Mar 28, 2024
Merged

Test/fix tests after ECS refactor #43

merged 1 commit into from Mar 28, 2024

Conversation

jasonqiu212
Copy link
Contributor

Resolves #42

@jasonqiu212 jasonqiu212 marked this pull request as ready for review March 28, 2024 12:46
@jasonqiu212 jasonqiu212 self-assigned this Mar 28, 2024
ruihan00
ruihan00 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ruihan00 ruihan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasonqiu212 jasonqiu212 merged commit 5794b02 into main Mar 28, 2024
1 check passed
@jasonqiu212 jasonqiu212 deleted the fix-tests branch March 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruihan00 ruihan00 ruihan00 approved these changes

Assignees

@jasonqiu212 jasonqiu212

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests after ECS refactor
2 participants
@jasonqiu212 @ruihan00