Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/remove sprite from persistence and remove unused assets #41

Merged
merged 6 commits into from Mar 28, 2024
Merged

Chore/remove sprite from persistence and remove unused assets #41

merged 6 commits into from Mar 28, 2024

Conversation

jasonqiu212
Copy link
Contributor

@jasonqiu212 jasonqiu212 commented Mar 28, 2024 •
edited

Resolves #34
Resolves #39

Changes

  • Remove sprite attribute from persistables, database, and mock data
  • Remove unused asset red-nose
  • Moved Events under GameEngine for organization
  • Grouped persistables under 1 folder for organization

@jasonqiu212 jasonqiu212 marked this pull request as ready for review March 28, 2024 10:29
@jasonqiu212 jasonqiu212 changed the title chore/remove sprite from persistence and remove unused assets Chore/remove sprite from persistence and remove unused assets Mar 28, 2024
HoJunHao2000
HoJunHao2000 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@HoJunHao2000 HoJunHao2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonqiu212 jasonqiu212 merged commit 25daed0 into main Mar 28, 2024
1 check passed
@jasonqiu212 jasonqiu212 deleted the chores branch March 28, 2024 11:55
@jasonqiu212 jasonqiu212 self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoJunHao2000 HoJunHao2000 HoJunHao2000 approved these changes

@Junyi00 Junyi00 Awaiting requested review from Junyi00

@ruihan00 ruihan00 Awaiting requested review from ruihan00

Assignees

@jasonqiu212 jasonqiu212

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage should not store sprite attribute Remove Extra Assets
2 participants
@jasonqiu212 @HoJunHao2000