Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture and Animations #20

Merged
merged 6 commits into from Mar 22, 2024
Merged

Texture and Animations #20

merged 6 commits into from Mar 22, 2024

Conversation

Junyi00
Copy link
Contributor

@Junyi00 Junyi00 commented Mar 22, 2024

Texture and Animations

This PR builds on the previous work to fully implement displaying textures and animations for entities.

NOTE: currently, the player still looks sluggish as it moves, which could be due to the texture or maybe some physics issues.

Changes

  • Define SpriteConstants to hold all sprites values
  • Update GameBridge to sync sprite information correctly
  • Updated Renderer to relay information when the joystick is released from the user to cancel run animation

@Junyi00 Junyi00 self-assigned this Mar 22, 2024
@Junyi00 Junyi00 requested review from ruihan00, jasonqiu212 and HoJunHao2000 and removed request for ruihan00 March 22, 2024 14:58
@Junyi00 Junyi00 marked this pull request as ready for review March 22, 2024 15:00
Copy link
Contributor

@ruihan00 ruihan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@HoJunHao2000 HoJunHao2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonqiu212 jasonqiu212 merged commit b7ed0de into main Mar 22, 2024
1 check failed
@jasonqiu212 jasonqiu212 deleted the feat/texture-and-animations branch March 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants