Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity Implementation #2

Merged
merged 7 commits into from Mar 13, 2024
Merged

Entity Implementation #2

merged 7 commits into from Mar 13, 2024

Conversation

ruihan00
Copy link
Contributor

Rough implementation of entity

  • Added Components
  • Added PlayerEntity
  • Added EntityManager

Things to consider

  • entity may be either sprite sheet or single image, either sprite component will handle that or we have 2 components
  • some way to represent sprite sheet and animation in sprite component

@ruihan00 ruihan00 marked this pull request as draft March 11, 2024 20:14
@jasonqiu212 jasonqiu212 reopened this Mar 12, 2024
@ruihan00
Copy link
Contributor Author

added entity implementation for the rest of the entities, missing test for now

@ruihan00 ruihan00 marked this pull request as ready for review March 13, 2024 02:55
jasonqiu212
jasonqiu212 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruihan00 ruihan00 merged commit 30202d3 into main Mar 13, 2024
@jasonqiu212 jasonqiu212 deleted the entity branch March 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@HoJunHao2000 HoJunHao2000 Awaiting requested review from HoJunHao2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruihan00 @jasonqiu212