Persistence #19
Merged
Persistence #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruihan00
commented
Mar 21, 2024
•
ruihan00
commented
- Added sqlite3 persistence
- Added Storage manager as a bridge between database and game
- Added json data file for 1 level
- Added loading of map in view controller (temporary to test)
- Added sprite size parameters to obstacle , tool entity
- Added sprite size health parameters to monster
…istence merge with latest changes
Junyi00
requested changes
Mar 22, 2024
jasonqiu212
reviewed
Mar 22, 2024
| // | ||
|
|
||
| import Foundation | ||
| struct LevelPersistable: Encodable, Decodable { |
There was a problem hiding this comment.
I think can just shorten into Codable
Comment on lines
19
to
20
| let entityPersistabls = self.database.getEntityPersistables(levelId: id) | ||
| return Level(levelPersistable: levelPersistable, entityPersistables: entityPersistabls) |
There was a problem hiding this comment.
entityPersistable typo
| private let entityTable = Table("entity") | ||
| private var db: Connection? | ||
|
|
||
| init() { |
There was a problem hiding this comment.
should we use a singleton design pattern for Database?
There was a problem hiding this comment.
I previously got marked down for singleton design pattern so not sure about this
| self.entities = entities | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Maybe can group LevelData and data.json into 1 folder for organization, since they both only deal with preloaded levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.