Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectibles #18

Merged
merged 13 commits into from Mar 22, 2024
Merged

Collectibles #18

merged 13 commits into from Mar 22, 2024

Conversation

Junyi00
Copy link
Contributor

@Junyi00 Junyi00 commented Mar 21, 2024

Collectibles

Implementation of a collectible with an example collectible called coin. The collectible will disappear, adding a score to the player.

Note: Currently the coin still appears as a player as the rendering of sprites have not been updated

Changes

  • Define contact bit mask for entities
  • Update physics body for collectibles to not fall due to gravity
  • Implementation for object removal in GameBridge and SDPhysicsEngine
  • Update SpriteModule to respect the size specified in SpriteComponent
  • Add a factory method for a coin collectible entity
  • Update Renderer, GameEngine and ViewController to display score information on the view

@Junyi00 Junyi00 self-assigned this Mar 21, 2024
@Junyi00 Junyi00 marked this pull request as ready for review March 21, 2024 15:19
@Junyi00 Junyi00 changed the title Feat/concrete collectibles Collectibles Mar 21, 2024
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the collectible disappear and the score change is so cool!

Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Junyi00 Junyi00 merged commit e01793f into main Mar 22, 2024
1 check failed
@jasonqiu212 jasonqiu212 deleted the feat/concrete-collectibles branch March 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants