Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/add camera #17

Merged
merged 13 commits into from Mar 25, 2024
Merged

feat/add camera #17

merged 13 commits into from Mar 25, 2024

Conversation

jasonqiu212
Copy link
Contributor

@jasonqiu212 jasonqiu212 commented Mar 21, 2024 •
edited

Changes

  • Add camera node to GameScene
  • Add logic to fix camera's x position using player's position
  • Miscellaneous fixes to fix typos and pass GitHub linter

Notes

  • For multiplayer, we need 1 distinct camera node for each player view. Since a SKScene contains only 1 camera node, we need to consider how to have distinct camera nodes for each player while not duplicating the same scene

@jasonqiu212 jasonqiu212 self-assigned this Mar 22, 2024
@jasonqiu212 jasonqiu212 marked this pull request as ready for review March 22, 2024 17:02
Junyi00
Junyi00 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Junyi00 Junyi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will work on top of these change for the split-screen rendering, thanks!

@jasonqiu212 jasonqiu212 merged commit d4eba34 into main Mar 25, 2024
1 check passed
@jasonqiu212 jasonqiu212 deleted the add-camera branch March 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junyi00 Junyi00 Junyi00 approved these changes

@ruihan00 ruihan00 Awaiting requested review from ruihan00

@HoJunHao2000 HoJunHao2000 Awaiting requested review from HoJunHao2000

Assignees

@jasonqiu212 jasonqiu212

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonqiu212 @Junyi00