Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/player move #16

Merged
merged 2 commits into from Mar 21, 2024
Merged

Feat/player move #16

merged 2 commits into from Mar 21, 2024

Conversation

Junyi00
Copy link
Contributor

@Junyi00 Junyi00 commented Mar 20, 2024

Player Movement

A naive implementation of player movement, a constant velocity applied to the character if the user's joystick is displaced.

Changes

  • Update PlayerComponent to include moving states. It determines whether the Player entity can move or jump at any point in time.
  • Renamed MoveEvent to TeleportEvent
  • Updated MoveEvent to apply a constant velocity to user movement (A naive implementation of movement for now)
  • Updated parameter names in delegates

Copy link
Contributor

@HoJunHao2000 HoJunHao2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonqiu212 jasonqiu212 merged commit fb52cc4 into main Mar 21, 2024
1 check failed
@jasonqiu212 jasonqiu212 deleted the feat/player-move branch March 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants