Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rich Text & Code/Markdown heading styling #741

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

zicklag
Copy link

@zicklag zicklag commented Jun 5, 2021

Hey there! This project is very cool!

I just found this today and might be contributing more if I can find the time. For now, here's a quick PR to ( subjectively ) improve the heading sytle in the markdown editor.

Also, this was super easy to get setup for development, which is great! 馃槂

Before

image

After

image

@zicklag
Copy link
Author

zicklag commented Jun 5, 2021

I also just pushed an update to the CkEditor heading styles which were previously very hard for me to read the different heading levels because they looked the same as unstyled text.

Before

image

After

image

@zicklag
Copy link
Author

zicklag commented Jun 5, 2021

For some reason the CkEditor styles aren't applied when printing. I'm trying to figure that out now.

@zicklag zicklag force-pushed the feature/markdown-heading-style branch 2 times, most recently from 90f8439 to 622232a Compare June 5, 2021 19:40
@zicklag
Copy link
Author

zicklag commented Jun 5, 2021

Just pushed a fix for the printing styles not being picked up, and I tweaked the ckeditor styles just slightly more to make it match the markdown preview styles:

image


Also, just curious, if this gets merged, what is the normal release cadence, or when I could expect this to get published to the live instance at cryptpad.fr?

@ansuz
Copy link
Contributor

ansuz commented Jun 23, 2021

I quickly reviewed this PR before our 4.7.0 release and noticed that it seemed to also affect styles in the code editor itself. It wasn't obvious why this would be the case and I haven't had the opportunity to dig into the problem yet, but I intend to so this can get merged.

For future reference, this would be easier to review if it were split into two PRs (for rich text and code), but that's not a blocking issue.

@ansuz
Copy link
Contributor

ansuz commented Jun 23, 2021

PS: thanks for the effort in the meantime!

@zicklag
Copy link
Author

zicklag commented Jun 23, 2021

For future reference, this would be easier to review if it were split into two PRs (for rich text and code), but that's not a blocking issue.

Gotcha. I'll do that in the future.

PS: thanks for the effort in the meantime!

No problem! Thanks for CryptPad! :)

@ghost ghost added Rich Text Related to the Rich Text app Code Related to the Markdown Code app labels Aug 8, 2022
@ghost ghost added the UI/UX Interfaces & user experience label Jun 8, 2023
@mathilde-cryptpad mathilde-cryptpad changed the base branch from main to staging March 26, 2024 09:25
@mathilde-cryptpad mathilde-cryptpad changed the title Improve Markdown Heading Styling Improve Rich Text & Code/Markdown heading styling Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Related to the Markdown Code app Rich Text Related to the Rich Text app UI/UX Interfaces & user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants