make mobile version of calendar close date field on 2nd button click #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Calendar app on mobile, if you click on the calendar date button it shows a date input field and that input field disappears if you set a date. If you don't, the input field stays unless you change the date by clicking on the calendar date button and change the current date. This fix makes it so that when the calendar date button is clicked and the input field is visible, it makes the input field invisible.
ghost
added
Calendar
ghost
requested a review
from 
|
Hello @cryptpad/maintainers, Hasn't this been already fixed recently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
In the Calendar app on mobile, if you click on the calendar date button it shows a date input field and that input field disappears if you set a date. If you don't, the input field stays unless you change the date by clicking on the calendar date button and change the current date.
This fix makes it so that when the calendar date button is clicked and the input field is visible, it makes the input field invisible.
Here's a mobile demo and a desktop demo:
mobile demo and desktop demo.