New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Windows debug launcher #2666
base: develop
Are you sure you want to change the base?
Conversation
-Dcryptomator.integrationsWin.autoStartShellLinkName="$AppName" \ | ||
-Dcryptomator.integrationsWin.keychainPaths="~/AppData/Roaming/$AppName/keychain.json" \ | ||
-Dcryptomator.showTrayIcon=true \ | ||
-Dcryptomator.buildNumber="msi-${REVISION_NUM}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might even add -dbg
here, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean a new jvm property (e.g., cryptomator.dbg
) which is read by the application?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No just the build number, so we know whether people started the debug launcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it! Yes, that's a good idea.
* substitute all java-options * use correct properties path * fix read-only attribute of debug launcher
Currently the jpackage build fails with:
Noteable is the first/second line. Seems like an internal JDK bug. I'll try to reproduce it with a minimal example. Interestingly, the debug executable is still build, only certain file properties cannot be altered. (Maybe a read-only problem?) |
Update: A ticket is created in the jdk issue tracker for it, see https://bugs.openjdk.org/browse/JDK-8303325. |
This PR is a follow up of #2661.
It was evaluated, if we could simply add
--win-console
(see jpackage doc) to our main application and avoid an additional launcher. But doing so would result in bad user experience: Everytime Cryptomator is started, also acmd
Terminal is started.Hence, to gather extended debug output on windows, we need the launcher. But we decided use it as general debug launcher (in contrast to former PR). This increases maintenance, but we'll be able to analyze with the help of users certain windows-related problems in more detail.