Remove unnecessary scopes and document required scopes #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This implementation depends on multiple (reasonable) assumptions and insights gained from the source code of MinIO: - "maxKeys" is implemented as page size: The iterator returned by "MinioClient.listObjects" automatically loads another batch of 0 <= count <= maxKeys results if the number of calls to the iterator exceeds the number of previously loaded results. The extension function "MinioClient.listObjectsLimit" limits the number of objects returned in total. - The iterator returned by "MinioClient.listObjects" will only return up to one error result. If there is an error result, it will always be returned as the next and only remaining result. - AWS as well as other S3 providers return the results of "listObjects" in a sorted fashion. This implementation breaks if a provider doesn't abide to this contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the call to
MinioClient#bucketExists, adds documentation on required scopes and closes #339.