Fix course list not refreshing and course page not redirecting after unenrolment #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a bunch of code to add the ability to unenrol students from courses. The method is hacky, involving creating an HTTP session using a private token, followed by emulating a HTML form submit to do the unenrolment. Unfortunately, Moodle doesn't have a webservice to allow for unenrolment. :(
…urses fragment after unenrolment 2 fixes were carried out on pull request crux-bphc#336 , namely :- 1)Course page still opens even after unenrolment. 2)Local course list does not refresh after unenrolment.
|
This PR has two merge commits that are totally necessary. I'm not sure if this a way to convert this directly into a linear history using an interactive rebase. You can always start the process from scratch in a separate branch and cherry pick your specific commit. I haven't gone through the code yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes were carried out on pull request #336, namely:-
1)Course page still opens even after unenrolment.
2)Local course list does not refresh after unenrolment.