feat(Makefile): Add checksums and tarballs for crank #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The checksums will help people to verify that their downloaded binary is not corrupted - The tarballs provide faster downloads, plus they can be useful for creating distro and brew packages, see crossplane#4899 Signed-off-by: Theo Chatzimichos <tampakrap@gmail.com>
jbw976
reviewed
Apr 26, 2024
There was a problem hiding this comment.
awesome to see your continued efforts @tampakrap! a scoping question for you about if this would be useful in other projects too 🤔
| @@ -143,6 +143,14 @@ e2e.init: build e2e-tag-images | |||
|
|
|||
| e2e.run: $(KIND) $(HELM3) e2e-run-tests | |||
|
|
|||
| build.artifacts.platform: build.artifacts.bundle.platform | |||
|
|
|||
| build.artifacts.bundle.platform: | |||
There was a problem hiding this comment.
what do we think about this being a more generally useful thing in the upbound/build submodule that has common build functionality and can be reused across multiple repos?
There was a problem hiding this comment.
Have a look at this diff please https://github.com/upbound/build/compare/master...tampakrap:upbound-build:introduce_build_artifacts_bundle_target?expand=1
Based on the above, the patch for this Makefile becomes the following:
build-artifacts-checksums-tarballs:
@mkdir -p $(abspath $(OUTPUT_DIR)/bundle/$(PLATFORM))
@$(SHA256SUM) $(GO_OUT_DIR)/crank$(GO_OUT_EXT) | head -c 64 > $(GO_OUT_DIR)/crank$(GO_OUT_EXT).sha256
@tar -czvf $(abspath $(OUTPUT_DIR)/bundle/$(PLATFORM)/crank).tar.gz -C $(GO_BIN_DIR) $(PLATFORM)/crank$(GO_OUT_EXT) $(PLATFORM)/crank$(GO_OUT_EXT).sha256
@$(SHA256SUM) $(OUTPUT_DIR)/bundle/$(PLATFORM)/crank.tar.gz | head -c 64 > $(OUTPUT_DIR)/bundle/$(PLATFORM)/crank.tar.gz.sha256
build.artifacts.bundle.platform: build-artifacts-checksums-tarballsLet me know what you think so I can proceed with the PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.