fix debug response when a response var is present #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the entire response returned by cue was also the crossplane response so it made sense to dump it as-is such that users could copy the request and response objects unmodified into their unit tests. Now that we support extracting a variable from the response, we need to replay it back with that variable such that copying the debug response output unmodified yields a correct test. That is, we do the same processing for responses as we do for requests. Signed-off-by: gotwarlost <krishnan.anantheswaran@elastic.co>
Mitsuwa
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the entire response returned by cue was also the crossplane response so it made sense to dump it as-is such that users could copy the request and response objects unmodified into their unit tests.
Now that we support extracting a variable from the response, we need to replay it back with that variable such that copying the debug response output unmodified yields a correct test. That is, we do the same processing for responses as we do for requests.