Fix bugs in the cue unit tester after the refactor #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gotwarlost
commented
May 3, 2024
gotwarlost
commented
- The default request variable was being set to "request" and not "#request" which was a late change in the prior commit
- Legacy options were not being correctly honored
- Add a new test for ensuring that lagcy options are honored correctly
* The default request variable was being set to "request" and not "#request" which was a late change in the prior commit * Legacy options were not being correctly honored * Add a new test for ensuring that lagcy options are honored correctly Signed-off-by: gotwarlost <krishnan.anantheswaran@elastic.co>
rbrunan
approved these changes
May 6, 2024
Mitsuwa
approved these changes
May 6, 2024
ydubreuil
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.