Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.25] OCPBUGS-33175: oci: keep track of exec PIDs and stop them on container stop #8106

Conversation

kwilczynski
Copy link
Member

@kwilczynski kwilczynski commented May 1, 2024

This is a manual cherry-pick of #7937

/assign kwilczynski

Related:

Keep track of exec calls for a container, and make sure to kill them when a container is being stopped

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 1, 2024
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl May 1, 2024 18:47
@kwilczynski kwilczynski changed the title oci: keep track of exec PIDs and stop them on container stop [release-1.25] oci: keep track of exec PIDs and stop them on container stop May 1, 2024
@kwilczynski
Copy link
Member Author

/hold

Pending merge of #8105.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@kwilczynski kwilczynski changed the title [release-1.25] oci: keep track of exec PIDs and stop them on container stop [release-1.25] OCPBUGS-33175: oci: keep track of exec PIDs and stop them on container stop May 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 1, 2024
@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-33175, which is invalid:

  • expected Jira Issue OCPBUGS-33175 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #7937

/assign kwilczynski

Keep track of exec calls for a container, and make sure to kill them when a container is being stopped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 43.54%. Comparing base (97431e1) to head (e1459fc).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.25    #8106      +/-   ##
================================================
- Coverage         43.63%   43.54%   -0.10%     
================================================
  Files               122      122              
  Lines             13749    13792      +43     
================================================
+ Hits               6000     6006       +6     
- Misses             7108     7144      +36     
- Partials            641      642       +1     

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
haircommander and others added 3 commits May 5, 2024 06:44
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/backport-7937-to-release-1.25 branch from e1459fc to 6d5a98b Compare May 4, 2024 21:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 4, 2024
@kwilczynski
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2024
@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9b807d6 into cri-o:release-1.25 May 13, 2024
33 of 41 checks passed
@openshift-ci-robot
Copy link

@kwilczynski: Jira Issue OCPBUGS-33175: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33175 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #7937

/assign kwilczynski

Related:

Keep track of exec calls for a container, and make sure to kill them when a container is being stopped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski deleted the feature/backport-7937-to-release-1.25 branch May 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants