Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use kata 3.3.0 for testing #7958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: use kata 3.3.0 for testing #7958

wants to merge 3 commits into from

Conversation

littlejawa
Copy link
Contributor

What type of PR is this?

/kind ci

What this PR does / why we need it:

Update the version of kata to test with - using the latest 3.3.0 version.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@littlejawa littlejawa requested a review from mrunalp as a code owner April 3, 2024 15:23
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 3, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.56%. Comparing base (d6f1f73) to head (a544f29).
Report is 72 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7958      +/-   ##
==========================================
- Coverage   49.58%   49.56%   -0.02%     
==========================================
  Files         153      153              
  Lines       16926    16955      +29     
==========================================
+ Hits         8392     8404      +12     
- Misses       7487     7504      +17     
  Partials     1047     1047

@kwilczynski
Copy link
Member

/retest-required

@kwilczynski
Copy link
Member

/approve

@kwilczynski
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 4, 2024
@kwilczynski
Copy link
Member

/retest-required

@littlejawa
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
@littlejawa
Copy link
Contributor Author

/test ci-fedora-kata

@kwilczynski
Copy link
Member

/retest

@sohankunkerkar sohankunkerkar mentioned this pull request Apr 19, 2024
Merged
@kwilczynski
Copy link
Member

/retest

@roman-kiselenko roman-kiselenko mentioned this pull request Apr 25, 2024
Open
@kwilczynski
Copy link
Member

/retest

@littlejawa
test: use kata 3.3.0 for testing
c123645 
Signed-off-by: Julien Ropé <jrope@redhat.com>
@littlejawa
Copy link
Contributor Author

littlejawa commented May 7, 2024 •
edited

Looks like I found how to do it... But I'm confused. I thought setting the storage option in the configuration file would work. We're doing it on the kata CI jobs, and it works.
But here, it doesn't: I have to use the environment variable.

Why? Is there an interaction with other options provided by env vars? Or because the storage driver is set on the command line?

I will clean things up so we can merge it with env var setting, but if anybody has an explanation for this behavior, I'm willing to learn.

@littlejawa
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@littlejawa
Copy link
Contributor Author

I think this one can be reviewed. @kwilczynski what do you think?

@littlejawa
ci: enable debug log level for the kata container runtime
bd31cbb 
Signed-off-by: Julien Ropé <jrope@redhat.com>
@littlejawa
test: kata test - set skip_mount_home in storage options
a544f29 
The kata runtime now runs in its own mount namespace.
Because of that, crio should not create a private bind mount,
otherwise the container rootfs can't be propagated to kata's namespace,
and the kata container can't access the rootfs files.

Signed-off-by: Julien Ropé <jrope@redhat.com>
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski, littlejawa
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwilczynski kwilczynski kwilczynski left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@kwilczynski kwilczynski

@littlejawa littlejawa

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littlejawa @kwilczynski