New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cri-o-runc source to install.md #7941
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrey Tvorozhkov <tvorog@tvorog.me>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @tvorogme. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tvorogme The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -572,6 +572,7 @@ and export it as a variable, like so: | |||
```shell | |||
rm /etc/apt/sources.list.d/devel:kubic:libcontainers:stable:cri-o:$VERSION.list | |||
|
|||
echo "deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/$OS/ /"| sudo tee /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tvorogme, can you provide a reproducer for this kind of issue? Usually the kubic repositories should not affected by changes in https://github.com/cri-o/packaging, so I'm wondering what we're missing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can start debian 11 container and run without change with OS Debian_11, on any version. It will not install cri-o-runc from apt (no such package). I add this echo from other tutorials and do apt install cri-o-runc
successfully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haircommander do we need crio-o-runc
for the kubic repos as well? I'm confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only for the legacy obs packages. I think we can have this but we are moving away from this packaging scheme so we'll soon no longer use cri-o-runc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7941 +/- ##
==========================================
- Coverage 48.94% 48.93% -0.01%
==========================================
Files 152 152
Lines 16452 16452
==========================================
- Hits 8052 8051 -1
- Misses 7424 7425 +1
Partials 976 976 |
A friendly reminder that this PR had no activity for 30 days. |
What type of PR is this?
I've installed Debian 11 and copy&run command from
install.md
, however it wasn't working dueE: Package 'cri-o-runc' has no installation candidate
, one of repo is forgottenWhat this PR does / why we need it:
To install cri-o WITH crio-o-runc, otherwise it'll not start
Which issue(s) this PR fixes:
General installation of cri-o on debian
Special notes for your reviewer:
Try to use those commands without my fix :)
Does this PR introduce a user-facing change?
None