Add image removal lock to image server #7850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note
openshift-ci
bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
saschagrunert
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
saschagrunert
force-pushed
the
image-removal-lock
branch
from
9fab9fb
to
1254e7b
Compare
saschagrunert
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
saschagrunert
force-pushed
the
image-removal-lock
branch
2 times, most recently
from
3bd60e4
to
4c520c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7850 +/- ##
==========================================
- Coverage 49.73% 49.71% -0.03%
==========================================
Files 153 153
Lines 16811 16841 +30
==========================================
+ Hits 8361 8372 +11
- Misses 7408 7425 +17
- Partials 1042 1044 +2 |
kwilczynski
reviewed
Mar 6, 2024
saschagrunert
force-pushed
the
image-removal-lock
branch
2 times, most recently
from
5e88f33
to
bd30ba3
Compare
saschagrunert
force-pushed
the
image-removal-lock
branch
2 times, most recently
from
70b6b21
to
8cb5dbe
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
github-actions
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
github-actions
bot
removed
the
lifecycle/stale
We now avoid removing images when a sandbox or container creation is in progress. This should close the gap in the outlined corner case in: kubernetes/kubernetes#123631 Refers to kubernetes/kubernetes#123711 as well. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
image-removal-lock
branch
from
8cb5dbe
to
64a606c
Compare
openshift-merge-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We now avoid removing images when a sandbox or container creation is in progress. This should close the gap in the outlined corner case in:
kubernetes/kubernetes#123631
Refers to kubernetes/kubernetes#123711 as well.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?