Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retrieve pull-secret using Red Hat SSO account #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgolovin
Copy link
Contributor

Fix #207.

This PR adds:

  1. Dependency to Red Hat Account extension
  2. Information message request how to configure pull-secret: using RH SSO account or doing it manually
    image
  3. Account Management API call to retrieve pull-secret and use it during first start

Considered other implementation options:

  1. Show Quick Picks instead of info message
  2. Always do it with Red Hat Account and use manual input as backup. The problem is when login sequence is started there is not way to cancel it.

src/crc-start.ts Show resolved Hide resolved
@dgolovin dgolovin requested a review from jeffmaury May 21, 2024 00:59
@jeffmaury jeffmaury changed the title feat: retrieve pull-sectret using Red Hat SSO account feat: retrieve pull-secret using Red Hat SSO account May 21, 2024
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me but I'm wondering we should enfore SSO use as manual retrieval is too complex. @slemeur WDYT ?

@slemeur
Copy link

slemeur commented May 21, 2024

Yes, we should enforce the use of SSO.
We could keep an option if the user wants to bring the pull secret - but that should not be the default path.

@dgolovin
Copy link
Contributor Author

This issue containers/podman-desktop#6632 should also be fixed to make workflow better. Right now the browser just pops up and one has no idea why.

@dgolovin
Copy link
Contributor Author

dgolovin commented May 21, 2024

We could keep an option if the user wants to bring the pull secret - but that should not be the default path.

The option already exists - pointing to file with pull-secret in extension settings.

image

Signed-off-by: Denis Golovin <dgolovin@redhat.com>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix packaging errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pull secret retrieval through API and integrate into workflow
3 participants