Merge pull request #208 from adrianriobo/fix-189

Show Full User Experience When Running The Installer On Windows
crc-org · Apr 22, 2024 · a2a650e · a2a650e
2 parents ef6facc + 1c3864a
commit a2a650e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/extension.ts b/src/extension.ts
@@ -289,7 +289,7 @@ async function initializeCrc(
   telemetryLogger: extensionApi.TelemetryLogger,
   logger: extensionApi.Logger,
 ): Promise<boolean> {
-  const hasSetupFinished = await setUpCrc(logger, false);
+  const hasSetupFinished = await setUpCrc(logger, true);
   if (hasSetupFinished) {
     await needSetup();
     await connectToCrc();

diff --git a/src/install/win-install.ts b/src/install/win-install.ts
@@ -41,7 +41,7 @@ export class WinInstall extends BaseInstaller {
           msiPath = await this.extractMsiFromZip(setupPath);
           progress.report({ increment: 10 });
 
-          const runResult = await runCliCommand('msiexec.exe', ['/i', msiPath, '/qr', '/norestart']);
+          const runResult = await runCliCommand('msiexec.exe', ['/i', msiPath, '/qf']);
           if (runResult.exitCode !== 0) {
             // installed successfully, but reboot required
             if (runResult.exitCode === 3010) {