Mail sender #1154
Open
Mail sender #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohitpanjwani
requested changes
Mar 14, 2023
| 'SES_KEY' => env('SES_KEY'), | ||
| 'SES_SECRET' => env('SES_SECRET'), | ||
| ]; | ||
| $this->insertData($settings, $company->id); |
There was a problem hiding this comment.
@yogesh-gohil Let's rename insertData to createSender
| $user->allow('create-mail-sender'); | ||
| $user->allow('edit-mail-sender'); | ||
| $user->allow('delete-mail-sender'); | ||
| BouncerFacade::allow($user)->toOwn(MailSender::class); |
Uffizzi Preview Environment☁️ https://app.uffizzi.com//github.com/crater-invoice/crater/pull/1154 ⚙️ Updating now by workflow run 4448044402. What is Uffizzi? Learn more |
|
Hi @yogesh-gohil and @mohitpanjwani, I'm searching for a resolution of issue #883 and came across this pull req. Can I check if it's safe to deploy or merge into my instance of Crater which I'm self hosting? Would the solution here resolve #883 ? Many thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneoption on mail encryption. closing option to send email without encryption #1130