Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed .htaccess file. #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proposed .htaccess file. #17

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2017

For the people who are able to use an .htaccess, it may solve a couple of problems.

bbannon added 2 commits July 31, 2017 11:38
It looks like only includes/js/v_h_scrolls.js made it here.
There are several more functions in here that I find useful.
php_flag magic_quotes_runtime Off
php_flag magic_quotes_sybase Off

php_value date.default_latitude 43.133
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would be setting default lot/lon to this value? Seems odd...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean "latutude/longitude"? Those are my area. I was looking to put in sunrise/sunset info on some page like month view.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there should be a way to get the users timezone from them. If we track them in user_prefs


php_value date.default_latitude 43.133
php_value date.default_longitude -115.6912
php_value date.timezone America/Boise
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, why override their system setting for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you're asking. If you mean things like 'magic_quotes' or 'register_global', I wanted to make sure I was coding without them.
If you mean 'default_charset' I was looking to make all translation/*.txt files UTF-8. Would eliminate half the files. And update_translation.pl used to barf on BOM files. Which is why Bulgarian.txt got corrupted.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to timezone here. Seems like if we include a version of this file, that value should be commented out with some info on how it can be used. Are you thinking the installer will write/update this file? Or it would just be a regular file included with the release?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, more comments. On all entries.
This one was supposed to be an example. Included with the release.
And on the admin page, (or maybe just the installer?), ask what the defaults should be and create the real file on the fly.
I intended for the system admin to set defaults for their site. Just once.
For instance, my ISP has timezone = UTC. I live in Idaho. Not very helpful.
If we could access GPS/location info, latitude/longitude, and track that in user_prefs, we could keep traveling boss/assistant timezones updated. Without trying to guess.


# 'magic_quotes' were removed in PHP 7.
# Remove these lines if you're using PHP >= 7.
php_flag magic_quotes_gpc Off
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice... to be able to force this setting off right from within webcalendar.

@@ -0,0 +1,558 @@
/* $Id: chapman.js,v 1.1 2013/01/30 10:02:28 bbannon Exp $ */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on what the intent for this new file is. How will this be used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly planning on using it for the Date functions.
Also, it has the scrollers from v_h_scrolls.js incorporated.
There are a couple of other functions that looked interesting but, I don't have solid plans for them, yet. I put them in just in case.

@craigk5n
Copy link
Owner

craigk5n commented Aug 2, 2017

Another thing to consider.... A lot of people use nginx now instead of Apache, and nginx does not support htaccess files.

@ghost
Copy link
Author

ghost commented Aug 3, 2017

hmmm... I've only seen nginx mentioned somewhere in passing.
I thought it was an extension to Apache. Not a replacement.
Is it something that users could install?
Or, is it just ISP level?

@craigk5n
Copy link
Owner

craigk5n commented Aug 3, 2017

I like the idea of providing it as an example. However, we would need to put the .htaccess file somewhere other than the root directory, or name it something else (.htaccess-example).

@ghost
Copy link
Author

ghost commented Aug 3, 2017

Good idea. Put it where it belongs just named .htaccess-example or something like that.

@ghost
Copy link
Author

ghost commented Aug 3, 2017

We might also want to put .htaccess in .gitignore.

@bbannon
Copy link
Contributor

bbannon commented Aug 17, 2017

I just watched a course on nginx at https://www.sitepoint.com/premium/courses/faster-websites-with-nginx-2757
(If you're not already a member, if you sign up for sitepoint premium at
https://www.sitepoint.com/premium/refer/bbannon
you get $25 off.)
Apparently, nginx CAN be used without Apache but, usually it handles static files (css,js,html,png,gif,etc) and sends everything else to Apache as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants