Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#797 making empty strings able to overwrite previous values #1072

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

floatingbits
Copy link

Description

Treating empty string as legal value that can overwrite current values and will not be ignored in further processing.

Related issues

#797

@boudewijn-zicht
Copy link
Contributor

@floatingbits Could you please take a look at this? It seems like a solution for several of our clients as well...

@floatingbits
Copy link
Author

@boudewijn-zicht I think you wanted to mention @angrybrad. He's the reviewer. I'm just a random developer who suggested a fix ;)

@boudewijn-zicht
Copy link
Contributor

Very good point 😄

Let me try that again...

@angrybrad Could you please take a look at this? It seems like a solution for several of our clients as well...

@angrybrad
Copy link
Member

@boudewijn-zicht yup, have a tab open to look at this, but it'll probably be next week.

@boudewijn-zicht
Copy link
Contributor

@boudewijn-zicht yup, have a tab open to look at this, but it'll probably be next week.

Awesome, that makes me very happy!

@mdoorschodt
Copy link

@boudewijn-zicht yup, have a tab open to look at this, but it'll probably be next week.

hi braid. this issue still hasn't been resolved. could you please look into this?

@mdoorschodt
Copy link

mdoorschodt commented Jan 12, 2023

hi @angrybrad, could you give us an update please? ik would be so nice if this could be resolved... i've got several clients with feeds that we can't process properly due to this issue

@tricki
Copy link

tricki commented Dec 5, 2023

This might have been fixed in 5.1.0:

Added the “Set Empty Values” feed setting, which determines whether empty values in the feed should be respected or ignored. (#1228, #797, #723, #854, #680)

Source: https://github.com/craftcms/feed-me/blob/develop/CHANGELOG.md#510---2023-03-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants