Merge pull request #296 from a-solaris/pr/fix-rounding-error

fix: Fix a potential rounding error
craftcms · Mar 28, 2024 · c19b378 · c19b378
2 parents df0770e + 6347b3d
commit c19b378
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Stripe for Craft Commerce
 
+## Unreleased
+
+- Fixed a bug where floating point rounding precision could cause payments/refunds to fail. ([#296](https://github.com/craftcms/commerce-stripe/pull/296))
+
 ## 4.1.2 - 2024-03-25
 
 - Fixed a bug where redirects could break when adding a new payment source. ([#259](https://github.com/craftcms/commerce-stripe/issues/259), [#289](https://github.com/craftcms/commerce-stripe/issues/289))

diff --git a/src/gateways/PaymentIntents.php b/src/gateways/PaymentIntents.php
@@ -287,7 +287,7 @@ public function refund(Transaction $transaction): RequestResponseInterface
             try {
                 $request = [
                     'charge' => $transaction->reference,
-                    'amount' => $transaction->paymentAmount * (10 ** $currency->minorUnit),
+                    'amount' => (int) bcmul($transaction->paymentAmount, 10 ** $currency->minorUnit),
                 ];
                 $refund = $this->getStripeClient()->refunds->create($request);
 
@@ -303,7 +303,7 @@ public function refund(Transaction $transaction): RequestResponseInterface
             if ($stripePaymentIntent->status == 'succeeded') {
                 $refund = $this->getStripeClient()->refunds->create([
                     'payment_intent' => $stripePaymentIntent->id,
-                    'amount' => $transaction->paymentAmount * (10 ** $currency->minorUnit),
+                    'amount' => (int) bcmul($transaction->paymentAmount, 10 ** $currency->minorUnit),
                 ]);
 
                 return $this->createPaymentResponseFromApiResource($refund);
@@ -638,7 +638,7 @@ protected function authorizeOrPurchase(Transaction $transaction, PaymentIntentFo
         }
 
         // Normalized amount for Stripe into minor units
-        $amount = $transaction->paymentAmount * (10 ** $currency->minorUnit);
+        $amount = (int) bcmul($transaction->paymentAmount, 10 ** $currency->minorUnit);
 
         /** @var PaymentIntentForm $form */
         if ($form->paymentFormType == self::PAYMENT_FORM_TYPE_CHECKOUT) {