Skip to content

Commit

Permalink
3.8.3 - fixed #199
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonkelly committed Mar 28, 2024
1 parent 2c3673c commit 2dada98
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Notes for CKEditor for Craft CMS

## 3.8.3 - 2024-03-28

- Fixed a bug where the `ckeditor/convert` command wasn’t checking for and removing the old `configFile` Redactor setting. ([#199](https://github.com/craftcms/ckeditor/issues/199))

## 3.8.2 - 2024-03-19

- Fixed a bug where the “Insert image” toolbar button wasn’t available when editing CKEditor configs. ([#195](https://github.com/craftcms/ckeditor/issues/195))
Expand Down
3 changes: 2 additions & 1 deletion src/console/controllers/ConvertController.php
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public function actionRedactor(): int
$ckeConfig = $this->generateCkeConfig($configName, $redactorConfig, $ckeConfigs, $fieldSettingsByConfig);
$this->stdout(PHP_EOL);
} else {
$basename = ($field['settings']['redactorConfig'] ?? null) ?: 'Default.json';
$basename = ($field['settings']['redactorConfig'] ?? $field['settings']['configFile'] ?? null) ?: 'Default.json';
if (!isset($configMap[$basename])) {
$this->stdout(PHP_EOL . PHP_EOL);
$configMap[$basename] = $this->resolveRedactorConfig($basename, $ckeConfigs, $fieldSettingsByConfig);
Expand All @@ -230,6 +230,7 @@ public function actionRedactor(): int

unset(
$field['settings']['cleanupHtml'],
$field['settings']['configFile'],
$field['settings']['configSelectionMode'],
$field['settings']['manualConfig'],
$field['settings']['redactorConfig'],
Expand Down

0 comments on commit 2dada98

Please sign in to comment.