Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Sanitizer #1717

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Memory Sanitizer #1717

wants to merge 4 commits into from

Conversation

thetic
Copy link
Contributor

@thetic thetic commented Dec 10, 2022 •
edited

MemorySanitizer is a detector of uninitialized reads.

  • We obviously can't run msan with leak detection enabled.
  • We have to disable the C++ standard library for msan. Unless we build it ourselves, it isn't instrumented, so generates false positives.
  • I had to disable all the MemoryLeakDetector tests for msan. I was surprised to discover that code is active, even when leak detection is disabled.

@coveralls
Copy link

coveralls commented Dec 10, 2022 •
edited

Coverage Status

Coverage remained the same at 99.323% when pulling 21b5437 on thetic:msan into c02ec75 on cpputest:master.

@thetic
Set up memory sanitizer
38974f8
@thetic
Disable C++ standard library
5a72c58 
Unless we build it ourselves, libc++ is uninstrumented and will create
false positives when running the memory sanitizer.
@thetic
FIXME: Disable failing msan tests
21b5437 
I don't know why the MemoryLeakDetector is active when leak detection is
disabled.
@thetic thetic marked this pull request as ready for review December 11, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thetic @coveralls