Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TestCase to TestSuite in GTestConvertor #1470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mickeykkim
Copy link

This commit changes references of testing::TestCase to testing::TestSuite in GTestConvertor.h. This is necessary to update Google Test integration to the latest version.

This commit changes testing::TestCase to testing::TestSuite in GTestConvertor.h. This is necessary to update Google Test integration to the latest version.
@NikosZampelis
Copy link

Please check lines 130 and 142 if you have the time... the GTEST_FLAG(internal_run_death_test) calls need further updates. I guess with the GTestFlagSaver class.

@basvodde
Copy link
Member

basvodde commented Dec 2, 2021

I think I cannot merge this as it is now. I want to, but we currently support GTest 1.4-1.7 and, as far as I can see, this change breaks the support for the previous versions. So, the changes will need to be in a new #ifdef (unfortunately). Or am I wrong about that?

@NikosZampelis
Copy link

@basvodde Unfortunately, you are correct. This would break older versions without #ifdefs. This PR needs to also be updated further as it does not update Google Test integration with the latest Google Test version. My previous comment is an example of the differences.
Note: Currently GTest is in version 1.11. Do you want to consider dropping support for older versions at some point?

@basvodde
Copy link
Member

basvodde commented Dec 6, 2021

We do not really want to stop the support of earlier versions. CppUTest is often used in large-embedded products and they are often stuck on an old version of a tool (or framework) and have trouble changing that. In order to help with that, we try to support as much old compilers/framework as possible. It also restricts the C++ that is used in building CppUTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants