-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add data limit fetch implementation #815
base: master
Are you sure you want to change the base?
add data limit fetch implementation #815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently unable to test on iOS so I am not sure if I will be able to include this in the upcoming release until I am able to test, but this is a great feature.
@@ -12,17 +12,10 @@ class HealthDataPoint { | |||
String _deviceId; | |||
String _sourceId; | |||
String _sourceName; | |||
String _uuid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason to add this new field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoffmatteo added only for simplify cuz plugin is not returning an uuid in general this means that we need to use another plugins to get uuid of user. In general this is more a draft which you can change if needed
final args = <String, dynamic>{ | ||
'dataTypeKey': dataType.name, | ||
'dataUnitKey': _dataTypeToUnit[dataType]!.name, | ||
'startTime': startTime.millisecondsSinceEpoch, | ||
'endTime': endTime.millisecondsSinceEpoch | ||
'endTime': endTime.millisecondsSinceEpoch, | ||
if (limit != null && limit > -1) 'limit': limit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is already implemented on the iOS side this is a great change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoffmatteo thanks mate 💖
Why are we making this pull request?
Original problem described: #581
Updates
Such as original plugins already contain
limit
parameter in ios native files, we could basically try to add this parameter togetHealthDataFromTypes
function.How to use
Callout: #706