[Health] Expose additional methods for HealthFactory #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lability on the go
marcsanny
changed the title
maxbeech
added a commit
to maxbeech/flutter-plugins
that referenced
this pull request
Oct 15, 2023
From this commit: cph-cachet#799
* feat: Additional platform specific data types (WIP) * fix: Refresh health connect client on chackAvailability call * chore: Bump dependencies * feat: Add support for Android 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it was only checked in onAttachedToEngine plugin method (once on initialization). Then after the user downloaded Health Connect, it was impossible to refresh the Health Connect availability status.
Steps to reproduce the current behavior:
HealthFactory(useHealthConnectIfAvailable: true).requestAuthorization(...);- it will fallback to Google Fit.HealthFactory(useHealthConnectIfAvailable: true).requestAuthorization(...);- it will fallback to Google Fit even tho we already have Health Connect.This PR allows to call checkAvalability() before requesting permission so that we won't fallback to Google Fit when we actually have Health Connect installed