refactor: rewrite settings to support object #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#947) * Change the command-line option --no-hot-exit to --no-restore-session. * Change the command-line option --no-hot-exit to --no-restore-session. * update * style: format codes * style: format codes Co-authored-by: Yufan You <ouuansteve@gmail.com> Co-authored-by: ChungZH <ChungZH@users.noreply.github.com>
Remove dependence to python3. Update build workflow for installing library. Update release workflow[win] to bundle yaml-cpp.dll. Update DEB/control. Update aur/*/PKGBUILD. Update snap/snapcraft.yaml.
Change genSettings.py to genSettings.cpp. Add new target for generated code. Update sources list.
Remove genSettings.py. Remove settings.json. Add settings.yaml.
Move data to SettingManager. Use SettingsHelper to access. Remove from/to variantlist as we no longer directly load or save.
Declare store type(QStringList) for yaml parser.
Adjust minimum width because the dialog frame has changed.
Fix button to language settings. Combine three buttons into one.
Use the rewrote wrapper. Add registerWidgets to support focusing to SettingBase.
Plz refer to old PR #858 for details.
Use the new template. Use the generated code for page creation. Reload settings for PreferencePage when the dialog get focused.
Add SettingIter for setting tracking with keys for object. Move some functions' implement to SettingsInfo.cpp Add calling method support. Add string formatting(replace @ to keys) support. Reconstruct SettingInfo. Add methods and replace onApply. Remove `old` support.
Introduce and changed to yaml format. Add YAML binding to some qt types. Remove old warnings. Add `load` for YAML and move `load` to `load_INI`. Same to `save`. Remove supporting to the old type `QMap:xxx`. Changed the logic for default value. Now we load the setting and fill up with default value. Remove support for getting the default value. Now we can get that from SettingsInfo directly. Use the rewrote SettingUpdater for different type.
Add backward compability for INI.
Transfer `Formatter`.
Transfer `Language`.
Transfer `Parentheses`.
Transfer `Snippets`.
Transfer `LSP`.
Transfer `Default Path`.
Transfer `Actions`.
Remove old backward compability.
Remove theme rename.
Remove editor status parse.
Fix config location after changing app name. This may be fixed by others already.
Add support to tristate.
Use SettingsHelper to rewrite logic using SettingsManager.
Use Application in application.hpp
This commit is just an exception.
neko-para
requested review from
a team,
coder3101,
ouuan and
swiftqwq
and removed request for
a team
|
After all, we still don't know how to solve that AUR build test failed🤔 |
ouuan
reviewed
Aug 4, 2021
Comment on lines
+135
to
+140
| add_library( | ||
| target_generated | ||
| OBJECT | ||
| src/Settings/SettingsInfo.hpp | ||
| ${CMAKE_BINARY_DIR}/generated/SettingsInfo.cpp | ||
| ) |
There was a problem hiding this comment.
I guess this caused the CI to fail. Why separate them as a library?
There was a problem hiding this comment.
check this
So I move the generated sources into another target to apply different clang-tidy setting.
8 tasks
ouuan
changed the title
This was
linked to
issues
Aug 6, 2021
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ouuan
added
work in progress
ouuan
added
high_priority
|
After all, what happended to this pr 🤔 |
ouuan
force-pushed
the
v7.0
branch
2 times, most recently
from
699b182
to
061f146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to replace the old PR #858 and helps reviewers to know what has changed.