fix: add space after checkbox in macintosh theme

[swiftqwq]

Description

Update RichTextCheckBox to add extra space after checkbox in macintosh theme.

Related Issues / Pull Requests

fix #871

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

• If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
• If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
• If needed, I have opened a pull request or an issue to update the documentation.
• If these changes are notable, they are documented in CHANGELOG.md.

Additional text

After changing theme, you need to restart CP Editor to make this work.

[ouuan]

@swift-zym Can you test removing this based on master:

cpeditor/src/Widgets/RichTextCheckBox.cpp

Line 71 in 09216ba

setStyleSheet("QCheckBox{spacing:4px;}");

[ouuan]

If #902 (comment) works, use that solution;
else if 4d784c3 works, use it;
if neither of them works, revert 4d784c3.

[swiftqwq]

If #902 (comment) works, use that solution;
else if 4d784c3 works, use it;
if neither of them works, revert 4d784c3.

Neither of them work.

[ouuan]

What is the value of style()->pixelMetric(QStyle::PM_CheckBoxLabelSpacing) in macintosh theme?

[swiftqwq]

What is the value of style()->pixelMetric(QStyle::PM_CheckBoxLabelSpacing) in macintosh theme?

2

[ouuan]

Does 4d784c3 add a spacing, though not necessarily wide enough?

[ouuan]

I just think it's not very good to hardcode a spacing size for a specific theme, as the theme may change in the future 🤔

[swiftqwq]

Does 4d784c3 add a spacing, though not necessarily wide enough?

No....

[swiftqwq]

I just think it's not very good to hardcode a spacing size for a specific theme, as the theme may change in the future 🤔

I just can't find better solution for it 😢

[neko-para]

I think it's ok. If really want to move it out, maybe add support for os-specified param in setting 🤔

[ouuan]

Or we can try to find a different way to implement #733.

[neko-para]

Or we can try to find a different way to implement #733.

Maybe a widget contains a HBoxLayout, with a QCheckBox and a clickable label? It should work.

[coder3101]

Or we can try to find a different way to implement #733.

Maybe a widget contains a HBoxLayout, with a QCheckBox and a clickable label? It should work.

It will work, but I am thinking 🤔 if it's a macOS Qt Style bug, instead of code change we can report/wait for Qt to fix it.

[ouuan]

if it's a macOS Qt Style bug, instead of code change we can report/wait for Qt to fix it.

This is a custom widget, so we need to find out if it's a Qt bug or our own fault.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.