Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vim mode #1270

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add support for vim mode #1270

wants to merge 12 commits into from

Conversation

coder3101
Copy link
Member

@coder3101 coder3101 commented Dec 16, 2023

Add vim mode ported from #516

Description

Vim mode is one of the most requested feature for the editor, this PR is an attempt to port the vim mode originally introduced in 516.

Related Issues / Pull Requests

Closes #220

Motivation and Context

How Has This Been Tested?

MacOS Sonoma

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

Todos

  • Update changelog with docs PR custom command link

@coder3101
Copy link
Member Author

Documenation PR: cpeditor/cpeditor.github.io#324

CHANGELOG.md Outdated Show resolved Hide resolved
@yashgosa
Copy link

yashgosa commented Feb 9, 2024

Why is this pr dormant, vim mode is one of the most requested feature. ++ for review

@coder3101
Copy link
Member Author

I am waiting for a new release cycle to begin before this PR can be merged. Currently alpha v6.12 (master) already has a new syntax highlighting editor and I don't want to push two biggest changes in a single release.

@ouuan I think we should start a new release cycle which will push syntax highlighting to beta. Or if new cycle doesn't make sense, a new beta release should be made.

People can try out beta easily because it doesn't involves building from source.

@ouuan
Copy link
Member

ouuan commented Feb 10, 2024

I'd like v7.0 instead of v6.12 and expect lots of regressions. e.g. the "extra margin" setting doesn't work.

And then we can make other planned breaking changes as well.

@coder3101
Copy link
Member Author

So what is your plan?

I thought we should create a v7.0 beta release from master (including KSH) while master contains other changes such as Vim emulation and other breaking changes. We will keep pushing changes to beta as patch releases from master (this gives us more people to test out stuff, not everyone is willing to build from source).

After testing, we can finally release 7.0.x to stable from beta.

@srqe
Copy link

srqe commented Feb 12, 2024

@ouuan ^

@funcdfs
Copy link

funcdfs commented May 10, 2024

It looks like the functionality of Vim has been fully developed, but the build process is quite complex. expect to get the latest Vim mode pkg With Vim mode included, this editor would be the most comprehensive and user-friendly one available with vim. Thank you for your development time input for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vim Mode
6 participants