Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gauge metric for number of self-hosted org runners #165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peterhalasz
Copy link
Contributor

Added a new metric for the number of self-hosted organization action runners

  • Added a new gauge metric github_actions_num_self_hosted_org_runners
  • Extracted the creation of the GithubClient

It's unclear to me whether reporting the total number of runners is enough by itself. I think the number stays the same even if the registered runners are offline...
Alternatively I could add a few labels to the metric like name, os, status, busy, etc. (Github API docs)
What do you think?

Signed-off-by: Peter Halasz <peter.halasz@live.com>
Signed-off-by: Peter Halasz <peter.halasz@live.com>
Copy link
Owner

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, can you show the results of this?

also if we dont set gh.runners-repos this metric will be collected as well?

@cpanato
Copy link
Owner

cpanato commented Feb 18, 2024

need a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants