core/remote/cozy: Use cozy-stack-client methods #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version brings a new `CozyStackClient.DocumentCollection.findAll()` method which allows us to fetch all documents matching a given mango selector without making use of cozy-client's redux store as Desktop does not make use of it.
Methods from cozy-client use a redux store to keep a local data cache which creates a large memory footprint for Desktop without benefits since we don't use that store. These methods wrap cozy-stack-client methods which make the calls to the remote Cozy without dealing with redux. Using them should make Desktop a little lighter.
taratatach
force-pushed
the
core/use-cozy-stack-client-methods-to-query
branch
from
4414816
to
f5a4375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods from cozy-client use a redux store to keep a local data cache
which creates a large memory footprint for Desktop without benefits
since we don't use that store.
These methods wrap cozy-stack-client methods which make the calls to
the remote Cozy without dealing with redux.
Using them should make Desktop a little lighter.
Please make sure the following boxes are checked: