WIP: Set build targets via electron builder config file #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
build/change-targets
branch
2 times, most recently
from
b0203b2
to
7a3ffcc
Compare
Built architectures can be defined per target via the Electron builder's configuration file. This is simpler to make binaries for specific architectures than via the command line arguments, especially on CIs where the same workflow or action could be used for multiple targets. We take the opportunity to make a Apple silicon build (i.e. `arm64`) for recent Mac computers alongside the x64 build.
taratatach
force-pushed
the
build/change-targets
branch
from
7a3ffcc
to
23f179a
Compare
CI build jobs can save files as artifacts attached to the job itself. It is a convenient way to access binaries built from a specific commit. This saves built executables or installers and the electron-updater last version manifests to Github Actions and AppVeyor jobs.
A try/catch surrounding the notarization request was preventing the macOS jobs from failing when the request failed. However, the notarization is mandatory for Cozy Desktop to be installable without security warnings. This removes the try/catch block so the build will fail with the notarization request.
taratatach
force-pushed
the
build/change-targets
branch
from
23f179a
to
77dceea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked: