[WIP] core: Use AtomWatcher on macOS #1677
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We probably don't want to do this at first. Just merge macOS support into master, so we can publish a new release. And test the new combo by enabling it in config file.
Temporary proof-of-concept. To be reimplemented as a macOS specific step just after producer. (captures would take the output of this new step)
sebn
commented
Jul 12, 2019
| const timeoutInMs = process.env.NODE_ENV === 'test' ? 1000 : 10000 | ||
| this.macOSBuffer = new LocalEventBuffer(timeoutInMs, batches => { | ||
| for (const batch of batches) { | ||
| this.process(batch) |
sebn
commented
Jul 12, 2019
| this.watcher = await watcher.watchPath( | ||
| this.syncPath, | ||
| { recursive: true }, | ||
| this.process | ||
| onEventBatch |
There was a problem hiding this comment.
should we regenerate all captures with buffer? (I believe they were regenerated before reintroducing the buffer)
There was a problem hiding this comment.
also is the buffer necessary or not?
taratatach
force-pushed
the
master
branch
2 times, most recently
from
8a36ecb
to
a9a996e
Compare
taratatach
force-pushed
the
master
branch
2 times, most recently
from
8d7d624
to
18fc74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can: